Comments on: Code review tools? http://blog.melchua.com/2008/10/14/code-review-tools/ Braindump of the Mel. Seek coherency and relevance at your own risk. Mon, 08 Mar 2010 12:36:58 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: Code Review Review « Dwins’s Weblog http://blog.melchua.com/2008/10/14/code-review-tools/comment-page-1/#comment-1139 Code Review Review « Dwins’s Weblog Thu, 16 Oct 2008 02:54:29 +0000 http://blog.melchua.com/2008/10/14/code-review-tools/#comment-1139 [...] Ideas by dwins on the October 16, 2008 Mel Chua writes about code review tools in a recent blog post, pondering whether a software code review tool could benefit OLPC (where she’s now employed, [...] [...] Ideas by dwins on the October 16, 2008 Mel Chua writes about code review tools in a recent blog post, pondering whether a software code review tool could benefit OLPC (where she’s now employed, [...]

]]> By: Martin http://blog.melchua.com/2008/10/14/code-review-tools/comment-page-1/#comment-1138 Martin Wed, 15 Oct 2008 15:44:33 +0000 http://blog.melchua.com/2008/10/14/code-review-tools/#comment-1138 I don't think Modrain/google code review is that big of a deal for OLPC's codebase. There just isn't that much code. The culture of code reviews is a much bigger problem. Recognizing that the purpose of code reviews is disseminating knowledge first and quality second is a big deal in fixing this: because people have to value knowing about each other's code. Of course there are cliques and everyone won't be able to review everyone else's code, but unless the knowledge dissemination goal is recognized, the process of getting people to value the code review process is doomed to fail because all the incentives will be badly targeted. Witness the stagnation of the code-review@lists.laptop.org mailing list. There just aren't enough people interested in knowing about each other's code. I didn't anything in Guido's talk that fostered your "cycle" of patches as opposed to "linear" patching. As he said that everything is developed on a trunk, I fail to see how Mondrain is helping any "cycle" of "ripening". I don't think this is at all an "inability to scale keeps us from scaling" problem. I think it's a very distracting issue; I'd spend your two hour sprint on a feature and figure out why people aren't contributing code - I doubt you'll find it's lack of code review that's the problem. I don’t think Modrain/google code review is that big of a deal for OLPC’s codebase. There just isn’t that much code. The culture of code reviews is a much bigger problem. Recognizing that the purpose of code reviews is disseminating knowledge first and quality second is a big deal in fixing this: because people have to value knowing about each other’s code. Of course there are cliques and everyone won’t be able to review everyone else’s code, but unless the knowledge dissemination goal is recognized, the process of getting people to value the code review process is doomed to fail because all the incentives will be badly targeted.

Witness the stagnation of the code-review@lists.laptop.org mailing list. There just aren’t enough people interested in knowing about each other’s code.

I didn’t anything in Guido’s talk that fostered your “cycle” of patches as opposed to “linear” patching. As he said that everything is developed on a trunk, I fail to see how Mondrain is helping any “cycle” of “ripening”.

I don’t think this is at all an “inability to scale keeps us from scaling” problem. I think it’s a very distracting issue; I’d spend your two hour sprint on a feature and figure out why people aren’t contributing code – I doubt you’ll find it’s lack of code review that’s the problem.

]]> By: Greg Marra http://blog.melchua.com/2008/10/14/code-review-tools/comment-page-1/#comment-1137 Greg Marra Wed, 15 Oct 2008 14:05:03 +0000 http://blog.melchua.com/2008/10/14/code-review-tools/#comment-1137 I loved using Mondrian this summer. It was completely integrated with all of the development tools, so it was completely transparent to use. The same command line util I used for everything regarding version control also let me send code reviews to people. This tight integration made things a lot smoother. I loved using Mondrian this summer. It was completely integrated with all of the development tools, so it was completely transparent to use. The same command line util I used for everything regarding version control also let me send code reviews to people. This tight integration made things a lot smoother.

]]>