Comments on: My first shell script: bundlemaker http://blog.melchua.com/2008/05/14/my-first-shell-script-bundlemaker/ Braindump of the Mel. Seek coherency and relevance at your own risk. Thu, 29 Jul 2010 16:44:01 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: Tom http://blog.melchua.com/2008/05/14/my-first-shell-script-bundlemaker/comment-page-1/#comment-712 Tom Sun, 18 May 2008 13:08:26 +0000 http://blog.melchua.com/2008/05/14/my-first-shell-script-bundlemaker/#comment-712 Here are some suggestions: - Set the arguments $1, $2, $3 tolocal variables to make it more readable, e.g. URL=$1, DEST=$2, LANG=$3 - Do some basic validation of the input arguments - e.g. URL starts with http, ftp, etc., DEST does not already exist as a directory, filename or $2.xol, DEST does not contain a slash "/", LANG is a supported language - Check return codes of key commands you execute - i.e. "if [$? -ne 0] then" -- in many instances, this is a fatal error so you'd cleanup and exit with some message. For example, check the return codes of wget, mkdir and zip. - Use 'rm -rf "$2"' with extreme caution - what if someone specified "/" as $2? As noted above, you should ensure that $2 does not already exist, etc. Here are some suggestions:

- Set the arguments $1, $2, $3 tolocal variables to make it more readable, e.g. URL=$1, DEST=$2, LANG=$3

- Do some basic validation of the input arguments – e.g. URL starts with http, ftp, etc., DEST does not already exist as a directory, filename or $2.xol, DEST does not contain a slash “/”, LANG is a supported language

- Check return codes of key commands you execute – i.e. “if [$? -ne 0] then” — in many instances, this is a fatal error so you’d cleanup and exit with some message. For example, check the return codes of wget, mkdir and zip.

- Use ‘rm -rf “$2″‘ with extreme caution – what if someone specified “/” as $2? As noted above, you should ensure that $2 does not already exist, etc.

]]> By: dwins http://blog.melchua.com/2008/05/14/my-first-shell-script-bundlemaker/comment-page-1/#comment-703 dwins Sat, 17 May 2008 14:24:16 +0000 http://blog.melchua.com/2008/05/14/my-first-shell-script-bundlemaker/#comment-703 hey Mel, I DRY'ed your script up a bit and updated the wiki. Note the (echo echo echo) pattern for the ini file, it's pretty handy. The paren's basically open a second shell so a sequence of commands can be redirected, etc. as one. hey Mel, I DRY’ed your script up a bit and updated the wiki. Note the (echo echo echo) pattern for the ini file, it’s pretty handy. The paren’s basically open a second shell so a sequence of commands can be redirected, etc. as one.

]]>